On 10/3/18 8:34 PM, Takashi Iwai wrote:
You are correct. It does not trigger a warning.
There are about 50 similar instances in the whole codebase. And, as they are just a few, what I'm trying to do is to replace them with the most commonly used form: "fall through"
Hm, then I'm not sure whether it's worth for further similar replacements. A term "fallthru" is also very commonly used, and the compiler knows it, too, so why bother to rewrite?
Not that common actually. There are more than 2000 instances of "fall through" and just ~50 of "fallthru" and ~40 of "fall thru"
I don't mean to revert the already applied changes, but maybe better to concentrate on fixing other real bugs (and/or real warnings).
Yeah. Sure thing. It's just that I sort of ran into those cases a few days ago.
Thanks -- Gustavo