1 Oct
2014
1 Oct
'14
2:37 p.m.
On Wed, Oct 01, 2014 at 11:28:46AM +0200, Jean-Francois Moine wrote:
Mark Brown broonie@kernel.org wrote:
- request_module("snd-soc-hdmi-codec");
- pdev = platform_device_register_resndata(&priv->hdmi->dev,
"hdmi-audio-codec",PLATFORM_DEVID_NONE,NULL, 0,&tda998x_hdmi_data,sizeof tda998x_hdmi_data);
Why is this request_module() needed? If there is a good reason for it we should have some documentation.
The reason is simple: as the HDMI CODEC is not declared in the DT, the associated module must be loaded in memory.
No, that doesn't make sense - there's absolutely no dependency on DT for module loading, non-DT boards work perfectly fine. Think about this for a minute, we don't have lots of request_module() calls in board files. You're working around some other bug here.