At Tue, 27 Aug 2013 08:41:43 +0000, Lin, Mengdong wrote:
Hi Takashi,
I revised the patches to use u8 to contain the raw value of device list entry. Please review.
Thanks, applied all patches now.
Takashi
Thanks Mengdong
-----Original Message----- From: Takashi Iwai [mailto:tiwai@suse.de] Sent: Tuesday, August 27, 2013 2:07 PM To: Lin, Mengdong Cc: alsa-devel@alsa-project.org Subject: Re: [PATCH v2 1/4] ALSA: hda - add flags and routines to get devices selection info for DP1.2 MST
At Tue, 27 Aug 2013 03:16:50 +0000, Lin, Mengdong wrote:
Hi Takashi,
-----Original Message----- From: Takashi Iwai [mailto:tiwai@suse.de] Sent: Monday, August 26, 2013 8:44 PM
+/* display pin's device list entry */ struct hda_devlist_entry {
- unsigned int present_detect:1;
- unsigned int eld_valid:1;
- unsigned int inactive:1;
+};
Can't it be simply an unsigned int containing the raw value? You defined the bit flag in the above, and copying the bit field from/to the bit flag looks redundant.
How about using "u8"? Since each device entry is only 4 bits in the response to "Get Device List
Entry" Control.
Yeah, u8 should be fine.
Takashi