Re: [PATCH v6 01/12] driver: platform: Add helper for safer setting of driver_override

On Sun, Apr 3, 2022 at 9:38 PM Krzysztof Kozlowski krzysztof.kozlowski@linaro.org wrote:

Several core drivers and buses expect that driver_override is a dynamically allocated memory thus later they can kfree() it.

However such assumption is not documented, there were in the past and there are already users setting it to a string literal. This leads to kfree() of static memory during device release (e.g. in error paths or during unbind):

kernel BUG at ../mm/slub.c:3960!
Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM
...
(kfree) from [<c058da50>] (platform_device_release+0x88/0xb4)
(platform_device_release) from [<c0585be0>] (device_release+0x2c/0x90)
(device_release) from [<c0a69050>] (kobject_put+0xec/0x20c)
(kobject_put) from [<c0f2f120>] (exynos5_clk_probe+0x154/0x18c)
(exynos5_clk_probe) from [<c058de70>] (platform_drv_probe+0x6c/0xa4)
(platform_drv_probe) from [<c058b7ac>] (really_probe+0x280/0x414)
(really_probe) from [<c058baf4>] (driver_probe_device+0x78/0x1c4)
(driver_probe_device) from [<c0589854>] (bus_for_each_drv+0x74/0xb8)
(bus_for_each_drv) from [<c058b48c>] (__device_attach+0xd4/0x16c)
(__device_attach) from [<c058a638>] (bus_probe_device+0x88/0x90)
(bus_probe_device) from [<c05871fc>] (device_add+0x3dc/0x62c)
(device_add) from [<c075ff10>] (of_platform_device_create_pdata+0x94/0xbc)
(of_platform_device_create_pdata) from [<c07600ec>] (of_platform_bus_create+0x1a8/0x4fc)
(of_platform_bus_create) from [<c0760150>] (of_platform_bus_create+0x20c/0x4fc)
(of_platform_bus_create) from [<c07605f0>] (of_platform_populate+0x84/0x118)
(of_platform_populate) from [<c0f3c964>] (of_platform_default_populate_init+0xa0/0xb8)
(of_platform_default_populate_init) from [<c01031f8>] (do_one_initcall+0x8c/0x404)

Provide a helper which clearly documents the usage of driver_override. This will allow later to reuse the helper and reduce the amount of duplicated code.

Convert the platform driver to use a new helper and make the driver_override field const char (it is not modified by the core).

...

+int driver_set_override(struct device *dev, const char **override,

•                   const char *s, size_t len)
  

+{

•   const char *new, *old;
  

•   char *cp;
  

•   if (!override || !s)
  

•           return -EINVAL;
  

Still not sure if we should distinguish (s == NULL && len == 0) from (s != NULL && len == 0). Supplying the latter seems confusing (yes, I see that in the old code). Perhaps !s test, in case you want to leave it, should be also commented.

Another approach is to split above to two checks and move !s after !len.

•   /*
  

•    * The stored value will be used in sysfs show callback (sysfs_emit()),
  

•    * which has a length limit of PAGE_SIZE and adds a trailing newline.
  

•    * Thus we can store one character less to avoid truncation during sysfs
  

•    * show.
  

•    */
  

•   if (len >= (PAGE_SIZE - 1))
  

•           return -EINVAL;
  

Perhaps explain the case in the comment here?

•   if (!len) {
  

•           device_lock(dev);
  

•           old = *override;
  

•           *override = NULL;
  

•           device_unlock(dev);
  

•           goto out_free;
  

You may deduplicate this one, by

goto out_unlock_free;

But I understand your intention to keep lock-unlock in one place, so perhaps dropping that label would be even better in this case and keeping it

kfree(old); return 0;

here instead of goto.

•   }
  

•   cp = strnchr(s, len, '\n');
  

•   if (cp)
  

•           len = cp - s;
  

•   new = kstrndup(s, len, GFP_KERNEL);
  

•   if (!new)
  

•           return -ENOMEM;
  

•   device_lock(dev);
  

•   old = *override;
  

•   if (cp != s) {
  

•           *override = new;
  

•   } else {
  

•           kfree(new);
  

•           *override = NULL;
  

•   }
  

•   device_unlock(dev);
  

+out_free:

•   kfree(old);
  

•   return 0;
  

+}