hi
On 7/8/20 2:55 PM, Pierre-Louis Bossart wrote:
On 7/8/20 4:11 AM, Arnaud POULIQUEN wrote:
Hi Pierre-Louis,
On 7/7/20 9:16 PM, Pierre-Louis Bossart wrote:
Fix W=1 warning. The table uni_tdm_hw is declared in a header included by multiple C file. This isn't really a good practice but for now using __maybe_unused makes the following warning go away.
sound/soc/sti/sti_uniperif.c:12: sound/soc/sti/uniperif.h:1351:38: warning: ‘uni_tdm_hw’ defined but not used [-Wunused-const-variable=] 1351 | static const struct snd_pcm_hardware uni_tdm_hw = { | ^~~~~~~~~~
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com
Thanks for the patch, Seems that the same patch has already been proposed by Lee: https://www.spinics.net/lists/arm-kernel/msg820327.html
that's right, we both fixed the same things, and this is the merged series. Do you mind providing a tag if you're ok with the change?
Sure, just need to known which one i should tag... I saw that you are discussing with Lee by default i ack both, i let you decide which one will be merged :)
Acked-by: Arnaud Pouliquen arnaud.pouliquen@st.com
Regards, Arnaud
sound/soc/sti/uniperif.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sti/uniperif.h b/sound/soc/sti/uniperif.h index 2dc2da5d458b..a16adeb7c1e9 100644 --- a/sound/soc/sti/uniperif.h +++ b/sound/soc/sti/uniperif.h @@ -1348,7 +1348,7 @@ struct sti_uniperiph_data { struct sti_uniperiph_dai dai_data; };
-static const struct snd_pcm_hardware uni_tdm_hw = { +static __maybe_unused const struct snd_pcm_hardware uni_tdm_hw = { .info = SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BLOCK_TRANSFER | SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_MMAP_VALID,