On Thu, Mar 05, 2009 at 12:31:41PM +0100, Daniel Mack wrote:
On Thu, Mar 05, 2009 at 10:53:57AM +0000, Mark Brown wrote:
The other option would be to use the TDM mode interface to set this up since that's roughly what it is; my main concern here is that we already have two ways of doing this and I'd like to try to keep the number down for consistency.
Probably a matter of taste, but IMO TDM mode is not the place either. Userspace could decide sending out 24bit samples out of a sudden (which the CPU DAI might accept) and in this case, you'd need some special logic in the board file again to set up deviders, time slots etc, right?
That's why the clocking interface is generally used here - it's more orthogonal.
Yes, I'm just thinking we should be able to use the same name for this with every format.
Ok, I now call them SND_SOC_DAIFMT_FF_{UNSPEC,16BIT,24BIT,32BIT}. Are you fine with these names?
Yes, though I'd still prefer to use an existing interface rather than add a new one.