20 Dec
2010
20 Dec
'10
4:57 p.m.
At Mon, 20 Dec 2010 16:42:02 +0000, Mark Brown wrote:
On Mon, Dec 20, 2010 at 05:05:51PM +0100, Takashi Iwai wrote:
Erm, subject might be wrong, but I'm too dizzy now.
I think you just mean "Factor out cache accesses" or something?
Yes, that sounds better. Also, no proper wording came to my mind about the stuff this patch touched. I should have wrote it as cache_ops or so.
+static inline bool set_cache_val(void *base, unsigned int idx,
unsigned int val, unsigned int word_size)+{
- if (word_size == 1) {
u8 *cache = base;Like Dimitris says these really do need to be switch statements. Otherwise it looks OK.
OK. Will resend shortly later.
thanks,
Takashi