On Tue, 13 Feb 2024 10:07:35 +0100, Michael S. Tsirkin wrote:
On Tue, Feb 13, 2024 at 10:02:24AM +0100, Takashi Iwai wrote:
On Tue, 13 Feb 2024 09:51:30 +0100, Aiswarya Cyriac wrote:
Fix the following warning when building virtio_snd driver.
" *** CID 1583619: Uninitialized variables (UNINIT) sound/virtio/virtio_kctl.c:294 in virtsnd_kctl_tlv_op() 288 289 break; 290 } 291 292 kfree(tlv); 293 vvv CID 1583619: Uninitialized variables (UNINIT) vvv Using uninitialized value "rc". 294 return rc; 295 } 296 297 /** 298 * virtsnd_kctl_get_enum_items() - Query items for the ENUMERATED element type. 299 * @snd: VirtIO sound device. "
Signed-off-by: Anton Yakovlev anton.yakovlev@opensynergy.com Signed-off-by: Aiswarya Cyriac aiswarya.cyriac@opensynergy.com Reported-by: coverity-bot keescook+coverity-bot@chromium.org Addresses-Coverity-ID: 1583619 ("Uninitialized variables") Fixes: d6568e3de42d ("ALSA: virtio: add support for audio controls")
Thanks, applied.
Takashi
Why did you apply it directly? The patch isn't great IMHO. Why not give people a couple of days to review?
Sure, we can wait. I applied it quickly just since it's an obvious fix and you haven't responded to the original patch over a month.
thanks,
Takashi