28 Feb
2011
28 Feb
'11
2:24 p.m.
On Mon, Feb 28, 2011 at 03:07:45PM +0100, Takashi Iwai wrote:
Though, the static definitions in channel_mapping.h aren't ideal. If these are referred from difference places, they should be external and defined only once.
I'm not sure what you mean. Do you suggest to make them external inside hdspmixer? Like with pixmaps.h?
Yes.
The static array definitions shouldn't be included in multiple files.
The patch was half ready when I noticed that the static arrays are only referenced exactly once in the whole code.
I could complete the patch, though there seems to be no real benefit from it at the moment.
Cheers
--
mail: adi@thur.de http://adi.thur.de PGP/GPG: key via keyserver