At Sat, 17 May 2008 02:14:12 +0400, Stas Sergeev wrote:
Hello.
Considering all the feedbacks I got, depending snd-pcsp on CONFIG_EXPERIMENTAL looks like the only safe way to get out of all the troubles at one go. :)
Can the attached patch be applied?
Thanks, applied to my tree for the next push (maybe tomorrow) together with other two patches.
Btw, it seems to me that the alsa-kernel hg tree somehow lacks a few snd-pcsp patches that the alsa git tree has... how have that happened and how can be fixed?
It's because I apply some patches first to my git tree so that it can be better sync'ed with Linus tree. I'll backport them to ALSA HG tree later.
So, if you work on 2.6.*-rc, please make a diff against git tree.
BTW, it'd be helpful if you put more texts in the changelog. I did cut-n-paste the mail text that looks suitable as changelogs, so far.
thanks,
Takashi
[2 pcsp_exp.diff <text/x-patch (7bit)>] # HG changeset patch # User Stas Sergeev stsp@users.sourceforge.net # Date 1210975452 -14400 # Node ID 49d310de8ac42e5c495cf39440f4fde307b39c75 # Parent 3887126bbd9ca422208e651d46f9f5385d409efe snd-pcsp: depend on CONFIG_EXPERIMENTAL
Signed-off-by: Stas Sergeev stsp@aknet.ru
diff -r 3887126bbd9c -r 49d310de8ac4 drivers/Kconfig --- a/drivers/Kconfig Fri May 16 22:01:53 2008 +0400 +++ b/drivers/Kconfig Sat May 17 02:04:12 2008 +0400 @@ -6,6 +6,7 @@ menu "Generic devices"
config SND_PCSP tristate "Internal PC speaker support"
- depends on EXPERIMENTAL depends on X86_PC && HIGH_RES_TIMERS depends on INPUT depends on SND