Re: [alsa-devel] [PATCH v7 6/7] ASoC: hdac_hda: add asoc extension for legacy HDA codec drivers

On Fri, 17 Aug 2018 22:37:22 +0200, Pierre-Louis Bossart wrote:

--- /dev/null +++ b/sound/soc/codecs/hdac_hda.c @@ -0,0 +1,485 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright(c) 2015-18 Intel Corporation.

+/*

• • hdac_hda.c - ASoC extensions to reuse the legacy HDA codec drivers
• • with ASoC platform drivers. These APIs are called by the legacy HDA
• • codec drivers using hdac_ext_bus_ops ops.
• */

+#include <linux/init.h> +#include <linux/delay.h> +#include <linux/module.h> +#include <linux/pm_runtime.h> +#include <sound/pcm_params.h> +#include <sound/soc.h> +#include <sound/hdaudio_ext.h> +#include <sound/hda_register.h> +#include "../../hda/local.h"

Is this header really needed? I don't see any code using the stuff in this patch.

thanks,

Takashi