On 31/08/2017 at 06:40:42 +0200, Christophe JAILLET wrote:
If 'clk_prepare_enable()' fails, we must release some resources before returning. Add a new label in the existing error handling path and 'goto' there.
Fixes: 260ea95cc027 ("ASoC: atmel: ac97c: Handle return value of clk_prepare_enable.") Signed-off-by: Christophe JAILLET christophe.jaillet@wanadoo.fr
And here is the fallout of the stupid, brainless "fixing" of issues reported by static analysis tools.
This clk_prepare_enable will never fail. If it was going to fail, the platform would never boot to a point were it is able to execute that code. It is really annoying to have so much churn for absolutely 0 benefit.
Anyway, Acked-by: Alexandre Belloni alexandre.belloni@free-electrons.com
sound/atmel/ac97c.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c index 30c64ab210d9..5ffefac2fa8f 100644 --- a/sound/atmel/ac97c.c +++ b/sound/atmel/ac97c.c @@ -785,7 +785,7 @@ static int atmel_ac97c_probe(struct platform_device *pdev) } retval = clk_prepare_enable(pclk); if (retval)
return retval;
goto err_prepare_enable;retval = snd_card_new(&pdev->dev, SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1, THIS_MODULE,
@@ -881,6 +881,7 @@ static int atmel_ac97c_probe(struct platform_device *pdev) snd_card_free(card); err_snd_card_new: clk_disable_unprepare(pclk); +err_prepare_enable: clk_put(pclk); return retval; } -- 2.11.0
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel