On Thu, Apr 16, 2009 at 06:44:54PM -0400, Naresh Medisetty wrote:
select SND_SOC_TLV320AIC23 if I2C select SND_SOC_TLV320AIC26 if SPI_MASTER select SND_SOC_TLV320AIC3X if I2C
- select SND_SOC_SPDIF select SND_SOC_TWL4030 if TWL4030_CORE select SND_SOC_UDA134X select SND_SOC_UDA1380 if I2C
This should be alphabetically sorted....
@@ -93,6 +94,8 @@ config SND_SOC_SSM2602
config SND_SOC_TLV320AIC23 tristate +config SND_SOC_SPDIF
tristate
...as should this. The same issue applies in the Makefile. You're also missing a blank line and your indentation seems wrong.
--- /dev/null +++ b/sound/soc/codecs/spdif_transciever.c @@ -0,0 +1,69 @@ +/*
- ALSA SoC DaVinci DIT driver
- TI DaVinci audio controller can operate in DIT (SPDI/F) where
- no codec is needed. This file provides stub codec that can be used
- in these configurations.
These comments need refreshing.
+static struct platform_driver davinci_dit_driver = {
- .probe = davinci_dit_probe,
- .remove = davinci_dit_remove,
- .driver = {
.name = "davinci-dit",.owner = THIS_MODULE,- },
+};
Better to s/davinci/spdif/ for the driver name everywhere - it'd look odd to be registering a DaVinci specific thing on another platform.
@@ -26,6 +26,7 @@ config SND_DM6467_SOC_EVM depends on SND_DAVINCI_SOC && MACH_DAVINCI_DM6467_EVM select SND_DAVINCI_SOC_I2S_MCASP select SND_SOC_TLV320AIC3X
select SND_SOC_SPDIF help Say Y if you want to add support for SoC audio on TI DaVinci DM6467 EVM platform.
This should be part of a separate patch which adds the code to hook up the DAI.