On Thu, 09 Apr 2020 20:58:17 +0200, Pierre-Louis Bossart wrote:
Add HDMI codec vid for the Intel ElkhartLake platform
I suppose this can go through ASoC tree unless HDA legacy driver supports the device.
hmm, good point. In short, both DSP and non-DSP usage continue to be possible, so HDA legacy driver can be used as well. This is a (positive) new problem of SOF now using common codec driver for HDMI. The patch got merged already (and I think this is ok as we specifically enable and test HDMI with the ASoC stack), but maybe in the future we can send these codec driver patches directly, and not via ASoC.
ElkhartLake support was added to the legacy driver a while back (5.3). Don't ask me why the hdmi codec id was not added at the time, it was indeed a miss. I chose to send this patch as part of the ASoC series, so that at least we have consistency. Takashi, if you prefer it that way feel free to take this patch in your tree, but then Mark would need a tag for the rest of this series. I agree with Kai that moving forward the hdmi codec parts should be better tracked. Thanks -Pierre