Re: [PATCH 9/9] ALSA: hda/realtek: Remove redundant init_hook() in alc_default_init()

On 2022-07-09 6:46 PM, Takashi Iwai wrote:

On Wed, 06 Jul 2022 14:02:30 +0200, Cezary Rojewski wrote:

...

snd_hda_gen_init() does that for every codec already.

Definitely not.

snd_hda_gen_init() calls init_hook of snd_hda_gen_spec.

OTOH, what you're trying to kill the init_hook call of alc_spec. Both are in different layers and they don't share the same callback.

I see the mistake now. This patch was generated when I was debugging one of the module-reload issues, and once it was fixed, double ->init_hook() caught my eye so I decided to add additional cleanup patch on top. Meh.

Thanks for paying attention and good review!

Regards, Czarek