Hi Andy,
Answer inline: ________________________________________
From: Andy Shevchenko andriy.shevchenko@linux.intel.com Sent: 26 March 2024 22:58 To: Xu, Baojun Cc: tiwai@suse.de; robh+dt@kernel.org; lgirdwood@gmail.com; perex@perex.cz; pierre-louis.bossart@linux.intel.com; Lu, Kevin; 13916275206@139.com; alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org; liam.r.girdwood@intel.com; yung-chuan.liao@linux.intel.com; broonie@kernel.org; soyer@irl.hu Subject: [EXTERNAL] Re: [PATCH v1 1/8] ALSA: hda/tas2781: Add tas2781 SPI-based driver
On Tue, Mar 26, 2024 at 09: 08: 58AM +0800, Baojun Xu wrote: > Add TXNW2781 support in smi. What is 'smi'? Can you make message less cryptic, please? Also explain why it should be in that list in scan. c. Code wise LGTM, so with commit message ZjQcmQRYFpfptBannerStart This message was sent from outside of Texas Instruments. Do not click links or open attachments unless you recognize the source of this email and know the content is safe.
ZjQcmQRYFpfptBannerEnd
On Tue, Mar 26, 2024 at 09:08:58AM +0800, Baojun Xu wrote:
Add TXNW2781 support in smi.
What is 'smi'? Can you make message less cryptic, please? Also explain why it should be in that list in scan.c.
SMI mean drivers/platform/x86/serial-multi-instantiate.c, it add multi-spi devices within one ACPI node, and it mentioned new device-ids must also be added to ignore_serial_bus_ids in drivers/acpi/scan.c.
An ACPI node example like below:
Scope (_SB.PC00.SPI0) { Device (GSPK) { Name (_HID, "TXNW2781") // _HID: Hardware ID Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings { Name (RBUF, ResourceTemplate () { SpiSerialBusV2 (...) SpiSerialBusV2 (...) } } } }
Code wise LGTM, so with commit message fixed, Reviewed-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
-- With Best Regards, Andy Shevchenko