On Fri, Oct 09, 2009 at 07:44:00AM +0200, Jarkko Nikula wrote:
On Thu, 8 Oct 2009 14:11:16 +0100 Mark Brown broonie@opensource.wolfsonmicro.com wrote:
What is an "AIC34b_dummy (block B)"? You probably want to split it out into a separate patch.
I think this is the reason why Eduardo mentioned my name in the commit log :-)
Yeah, I mentioned Jarkko because he was the person who initially wrote those drivers :-).
But I can split then if you prefer. No problem.
Yep, dummy driver is for block B of AIC34 which is basically dual AIC33 in a same package.
Yes. This is correct.
- TODO:
- Get rid of this driver, at least when ASoC v2 is merged and when
- we can support multiple codec instances in tlv320aic3x.c driver.
- This driver is hacked only for Nokia RX51 HW.
Could you please explain what the issue here is? A description of the hardware would go a long way here.
Eduardo, please correct me if I remember wrong but block B of AIC34 is not used as an codec as such but more like an amplifier and analogic mixer with digital parts unused. So with this dummy driver the HW features were easier to support than to develop multiple intance support for codec drivers.
Yes. This is also correct. It is more like an amplifier / mixer. I think that's why you named it dummy :-).
But I think I should add this info as a comment inside the code.
-- Jarkko