Hi Charles,
sorry for jumping in..
On 19-07-30 13:27, Charles Keepax wrote:
On Tue, Jul 30, 2019 at 01:09:35PM +0100, Thomas Preston wrote:
Signed-off-by: Thomas Preston thomas.preston@codethink.co.uk Cc: Patrick Glaser pglaser@tesla.com Cc: Rob Duncan rduncan@tesla.com Cc: Nate Case ncase@tesla.com
.../devicetree/bindings/sound/tda7802.txt | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/tda7802.txt
diff --git a/Documentation/devicetree/bindings/sound/tda7802.txt b/Documentation/devicetree/bindings/sound/tda7802.txt new file mode 100644 index 000000000000..f80aaf4f1ba0 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/tda7802.txt @@ -0,0 +1,26 @@ +ST TDA7802 audio processor
+This device supports I2C only.
+Required properties:
+- compatible : "st,tda7802" +- reg : the I2C address of the device +- enable-supply : a regulator spec for the PLLen pin
Shouldn't that be a pin called 'pllen-gpios'? IMHO I would not use a regulator for that.
Regards, Marco
+Optional properties:
+- st,gain-ch13 : gain for channels 1 and 3 (range: 1-4) +- st,gain-ch24 : gain for channels 2 and 3 (range: 1-4)
I wouldn't have expected the gains to be available as a device tree setting.
+- st,diagnostic-mode-ch13 : diagnotic mode for channels 1 and 3
values: "Speaker" (default), "Booster"+- st,diagnostic-mode-ch24 : diagnotic mode for channels 2 and 4
values: "Speaker" (default), "Booster"+Example:
+amp: tda7802@6c {
- compatible = "st,tda7802";
- reg = <0x6c>;
- enable-supply = <&_enable_reg>;
+};
2.21.0
Thanks, Charles