11 Aug
2008
11 Aug
'08
10:52 a.m.
On Mon, 11 Aug 2008, Takashi Iwai wrote:
Hi,
as some people already mentioned, we have a pretty ugly macro, snd_assert(). Actually, this macro is sometimes useful, but the implementation including the code flow in arguments is really bad.
I tried to kill this, either the following way:
- replace snd_assert(cond, flow...); with if (snd_BUG_ON(!cond)) flow...;
For my eyes, many uses of snd_assert with direct 'return VALUE' are more "sexy", easy understandable and smaller. But, as mentioned, when goto is used to change the code flow, we end up with a compiler warning. It should be eliminated.
I have no strong objections to accept this change as you proposed. Thank you for your work.
Jaroslav
----- Jaroslav Kysela perex@perex.cz Linux Kernel Sound Maintainer ALSA Project, Red Hat, Inc.