On Sat, Jul 27, 2013 at 01:05:22PM +0100, Mark Brown wrote:
On Sat, Jul 27, 2013 at 01:31:50PM +0200, Markus Pargmann wrote:
This is a really nice approach to the problem, just one thing I'd like to see changed in the bindings:
+ssi {
- ...
- pinctrl-names = "default", "ac97-running", "ac97-reset", "ac97-warm-reset";
I'd like to see some documentation of this "default" state - I'd expect this corresponds to the bus being idle and waiting for a wakeup from the CODEC which is definitely a useful state to have for power optimisation so it'd be good to bake it into the bindings.
Alternatively it could be the bus being totally idle with no possibility of wakeup in which case it'd be good to say that too then someone can add the waiting for wakeup state later.
The "default" state is actually just the default pin state that is set before the driver is probed. I will remove it from the example. I didn't add a low power state although it might be usefull and is defined by the standard.
Please also note the new list devicetree@vger.kernel.org.
Yes thanks.
Regards,
Markus