2 Jun
2015
2 Jun
'15
1:42 p.m.
On Mon, Jun 01, 2015 at 07:32:14AM +0200, Takashi Iwai wrote:
Vinod Koul wrote:
- ret = request_threaded_irq(hda->pci->irq, azx_interrupt,
azx_threaded_handler,hda->msi ? 0 : IRQF_SHARED,KBUILD_MODNAME, sbus);
Why not just always request the interrupt as shared - we don't seem to care in the interrupt handling code?
I think we can move this to shared only
MSI is the exclusive irq, thus shouldn't be shared.
Why does the driver care though? IRQF_SHARED is advertising the capabilities of the hander, not a requirement on the hardware - if the interrupt physically can't be shared then the ability to share it will never get used but that shouldn't matter.