17 Dec
2015
17 Dec
'15
1:12 p.m.
On Thu, Dec 17, 2015 at 05:21:05AM +0000, Bard Liao wrote:
This is something I'd expect the machine driver to handle - if it's stopped using the PLL I'd expect it to explicitly turn it off, suspend (or the CODEC going idle for that matter normally, the PLL is burning power) should do that. If anything I'd expect the CODEC driver to restore the current settings.
The main reason of this patch is MX-7Bh(RT5677_PLL1_CTRL2) is volatile. However, the status bit of MX-7Bh is currently not used by codec driver. So, it should be no problem if we set it non-volatile.
That said I'll apply this since it at least doesn't make things worse.
Can we revert it and resend a patch?
Sure.