On Sat, Mar 26, 2011 at 08:21, Mark Brown wrote:
On Sat, Mar 26, 2011 at 04:33:46AM -0400, Mike Frysinger wrote:
select SND_SOC_AD1980 if SND_SOC_AC97_BUS
- select SND_SOC_ADS117X
select SND_SOC_AD73311 if I2C
- select SND_SOC_AD74111
- select SND_SOC_ADS117X
A few of your patches have this sort of additional change in them. While the cleanup is good it would be better to split it into a separate patch. Seeing the unrelated change slows down review and it'll also create extra merge issues when applying or cherry picking the driver back to older kernels.
in general i agree, but for moving literally one line i dont generally worry about it
+static struct platform_driver ad74111_codec_driver = {
- .driver = {
- .name = "ad74111-codec",
Again, drop the -codec unless this is part of a MFD.
when i looked at the history of things, it seemed like it's the ASoC maintainers sticking "-codec" on stuff. so should i go through existing drivers and revert that back ? -mike