Re: [alsa-devel] [PATCH v2] Add support for tlv320aic3007 to tlv320aic3x codec.

Applied but...

...

+static const struct i2c_device_id aic3x_i2c_id[] = {

• [AIC3X_MODEL_3X] = { "tlv320aic3x", 0 },
• [AIC3X_MODEL_33] = { "tlv320aic33", 0 },
• [AIC3X_MODEL_3007] = { "tlv320aic3007", 0 },
• { }

+}; +MODULE_DEVICE_TABLE(i2c, aic3x_i2c_id);

The more idiomatic way to write this stuff is:

{ "tlv320aic3007", AIC3X_MODEL_3007 }

and then look at the id field in the probe() function.  Could you send a followup patch doing that, please?

The second field in that struct is normally the i2c address, so this seems a bit confusing...

randolph