Re: [PATCH 1/2] ASoC: tegra30: ahub: Use of_device_get_match_data

On Mon, Aug 16, 2021 at 07:39:06PM +0100, Mark Brown wrote:

On Sun, Aug 15, 2021 at 01:42:18AM +0530, Aakash Hemadri wrote:

...

• match = of_match_device(tegra30_ahub_of_match, &pdev->dev);

• match = of_device_get_match_data(&pdev->dev); if (!match)

Thierry, are you sure about your review here? As others have been pointing out of_device_get_match_data() returns match->data while of_match_device() returns the device.

Ugh... good catch. I (naively) assumed this was a mechanical conversion like one of the many others that have been making the rounds and evidently wasn't paying enough attention.

Thanks for spotting this, Bjorn!

Thierry