Re: [PATCH v2] ALSA: hda: generic: Remove redundant assignment to dac

On Thu, 13 May 2021 13:11:11 +0200, Jiapeng Chong wrote:

Variable dac is set to zero, but this value is never read as it is overwritten or not used later on, hence it is a redundant assignment and can be removed.

Clean up the following clang-analyzer warning:

sound/pci/hda/hda_generic.c:1436:4: warning: Value stored to 'dac' is never read [clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot abaci@linux.alibaba.com Signed-off-by: Jiapeng Chong jiapeng.chong@linux.alibaba.com

---

Changes in v2: -For the follow advice: https://lore.kernel.org/patchwork/patch/1423536/

Thanks, applied.

Takashi