On Friday 24 November 2017 01:41 PM, Guenter Roeck wrote:
On Fri, Nov 24, 2017 at 3:07 AM, Mukunda,Vijendar vijendar.mukunda@amd.com wrote:
On Thursday 23 November 2017 10:59 PM, Mark Brown wrote:
On Thu, Nov 23, 2017 at 08:59:43AM -0800, Guenter Roeck wrote:
On Thu, Nov 23, 2017 at 8:30 AM, Vijendar Mukunda Vijendar.Mukunda@amd.com wrote:
added error checks in acp dma driver Signed-off-by: Vijendar Mukunda Vijendar.Mukunda@amd.com Signed-off-by: Akshu Agrawal Akshu.Agrawal@amd.com Signed-off-by: Guenter Roeck groeck@chromium.org
This is inappropriate.
Specifically: if Guenter wasn't involved in writing or forwarding the patch he shouldn't have a signoff in there, and if you're the one sending the mail you should be the last person in the chain of signoffs. Please see SubmittingPatches for details of what a signoff means and why they're important.
This patch was implemented on top of changes implemented by Guenter. There is a separate thread - RE: [PATCH] ASoC: amd: Add error checking to probe function in which Guenter posted changes.
That was my patch. This is yours.
Guenter
Got it , Let your patch go as it is. Will submit a fresh patch for additional error checks in acp dma driver.
Got it, apologies will post changes as v2 version.