Re: [alsa-devel] [PATCH v2] drm/i915: set proper N/CTS in modeset

On 2015-09-25 03:36, libin.yang@intel.com wrote:

@@ -24,8 +24,18 @@ #ifndef _I915_COMPONENT_H_ #define _I915_COMPONENT_H_

+/* MAX_PORT is the number of port

• • It must be sync with I915_MAX_PORTS defined i915_drv.h
• • 5 should be enough as only HSW, BDW, SKL need such fix.
• */

+#define MAX_PORTS 5

• struct i915_audio_component { struct device *dev;
• /**

• * @aud_sample_rate: the array of audio sample rate per port
  

• */
  

• int aud_sample_rate[MAX_PORTS];

Just a quick question as I was trying to understand the code:

aud_sample_rate seems only set and get on the i915 side, never on the hda side.

In short, why is this variable here, and not in e g, as a single integer in the intel_digital_port struct?

That way we also avoid the possibility of MAX_PORTS becoming out of sync with the i915 side.