Re: [PATCH] ASoC: dt-bindings: cirrus,cs4270: Convert to dtschema

On 07/07/2024 08:26, Animesh Agarwal wrote:

• reg:
• maxItems: 1
• reset-gpios:
• description:

•  This pin will be deasserted before communication to the codec starts.
  

• maxItems: 1
• va-supply:
• description: Voltage regulator phandle for the VA supply.

Your description is redundant: you did not say anything more than it is already said in the property name. This could be in such case just: ": true"

Please keep this feedback for any future work (I feel I already said it once...).

• vd-supply:
• description: Voltage regulator phandle for the VD supply.
• vlc-supply:
• description: Voltage regulator phandle for the VLC supply.

+required:

• • compatible
• • reg

+additionalProperties: false

This won't validate DTS... test the DTS. You miss dai-common.

+examples:

• • |
• i2c {

•  #address-cells = <1>;
  

•  #size-cells = <0>;
  

•  codec: cs4270@48 {
  

Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetre... e.g. audio-codec or codec

And drop unused label "codec:"

Best regards, Krzysztof