Re: [alsa-devel] [PATCH 1/1] ASoC: TWL4030: Add support Voice DAI

On Thursday 09 April 2009 17:06:54 ext Mark Brown wrote:

On Thu, Apr 09, 2009 at 10:54:37PM +0900, Joonyoung Shim wrote:

...

• /* change rate and set CODECPDZ */
  

• twl4030_codec_enable(codec, 0);
  

• twl4030_write(codec, TWL4030_REG_CODEC_MODE, mode);
  

• twl4030_codec_enable(codec, 1);
  

Hrm. This codec_enable() call looks fishy - what's the effect if the other DAI is running when the voice DAI is configured? Though there may be no way round this...

The TRM is not that clear on what changes in the CODEC_MODE register needs a codec reset. Changing the OPT_MODE does need a reset, most probably other fields also..