On Wed, 2018-01-03 at 10:50 -0600, Pierre-Louis Bossart wrote:
From: Vinod Koul vinod.koul@intel.com
Helps in finding if endings
Seems some (all?) comments not been addressed. See below.
config SND_SOC_INTEL_BAYTRAIL
- tristate "Intel ASoC SST driver for Baytrail (legacy)"
- tristate "Baytrail (legacy) Platforms" depends on DMADEVICES && ACPI select SND_SOC_INTEL_SST select SND_SOC_INTEL_SST_ACPI
@@ -73,7 +73,7 @@ config SND_SOC_INTEL_BAYTRAIL not recommended, use SND_SST_ATOM_HIFI2_PLATFORM instead.
config SND_SST_ATOM_HIFI2_PLATFORM_PCI
- tristate "Intel ASoC SST driver for PCI HiFi2 platforms
(Medfield, Merrifield)"
- tristate "PCI HiFi2 platforms (Medfield, Merrifield)
platforms"
platforms ... platforms.
Moreover, perhaps use above pattern "... Platforms" ?
depends on X86 && PCI select SND_SST_IPC_PCI select SND_SOC_COMPRESS @@ -87,7 +87,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI is not in the standard firmware tree
config SND_SST_ATOM_HIFI2_PLATFORM
- tristate "Intel ASoC SST driver for ACPI HiFi2 platforms
(Baytrail, Cherrytrail)"
- tristate "ACPI HiFi2 platforms (Baytrail, Cherrytrail)
Platforms"
Ditto.
config SND_MFLD_MACHINE
- tristate "SOC Machine Audio driver for Intel Medfield MID
platform"
- tristate "Intel Medfield MID"
Perhaps "Medfield (Intel MID)" ?
At least it looks to me more consistent with the rest.
config SND_SOC_INTEL_HASWELL_MACH
- tristate "ASoC Audio DSP support for Intel Haswell Lynxpoint"
- tristate "Haswell Lynxpoint" depends on X86_INTEL_LPSS && I2C && I2C_DESIGNWARE_PLATFORM select SND_SOC_RT5640 help
config SND_SOC_INTEL_BROADWELL_MACH
- tristate "ASoC Audio DSP support for Intel Broadwell
Wildcatpoint"
- tristate "Intel Broadwell Wildcatpoint"
Drop Intel.