Re: [alsa-devel] [PATCH] tlv320aic3x: control additions and cleanups

Hi,

On Fri, Dec 05, 2008 at 01:42:58PM +0000, Mark Brown wrote:

Hrm. This looks like it just substitutes two single controls for one stereo control, which seems reasonable and shouldn't loose any control:

...

•   SOC_DOUBLE_R("HP PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL,
  

•                PGAR_2_HPROUT_VOL, 0, 0x7f, 1),
  

•   SOC_SINGLE("HPL PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL,
  

•                0, 0x7f, 1),
  

•   SOC_SINGLE("HPR PGA Bypass Playback Volume", PGAL_2_HPROUT_VOL,
  

•                0, 0x7f, 1),
  

Possibly the controls are mislabeled?

As this is commited already, I'd like to make the naming cleanup part of the patch with the "DAC" string removals. Is that ok for you?

Apart from that, can the other one be applied?

Best regards, Daniel