Re: [alsa-devel] [PATCH] [ALSA] soc - fsl_ssi.c fix "BUG: scheduling while atomic"

On Thu, May 08, 2008 at 02:19:36PM -0500, Timur Tabi wrote:

Anton Vorontsov wrote:

...

We must not sleep with irqs disabled, so replace msleep with mdelay.

Signed-off-by: Anton Vorontsov avorontsov@ru.mvista.com

Acked-By: Timur Tabi timur@freescale.com

Anton, can you try testing the code with the call to mdelay/msleep commented out?

Ok, I'll try...

On my quick test, I didn't need it, so I have a suspicion that it was needed only for the old 1.0 silicon.

Are there any drawbacks of mdelay'ing? Since some silicons need this we'd better leave it then.