Re: [alsa-devel] [PATCH] ALSA: off by 1 in snd_emu10k1_wait()

At Thu, 16 Apr 2009 23:54:04 +0200, Roel Kluin wrote:

Is this useful? It was in Linus' git tree.

Well, I guess it won't change any real behavior, but a bug is a bug :) Applied now.

Thanks,

Takashi

----------------------------->8-----------------8<------------------------------ With `while (count++ < 16384)' count reaches 16385.

Signed-off-by: Roel Kluin roel.kluin@gmail.com

diff --git a/sound/pci/emu10k1/io.c b/sound/pci/emu10k1/io.c index 4bfc31d..c1a5aa1 100644 --- a/sound/pci/emu10k1/io.c +++ b/sound/pci/emu10k1/io.c @@ -490,7 +490,7 @@ void snd_emu10k1_wait(struct snd_emu10k1 *emu, unsigned int wait) if (newtime != curtime) break; }

• if (count >= 16384)
  

• if (count > 16384)
  break;
  

  curtime = newtime; }

---

Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel