Re: [alsa-devel] [PATCH] ALSA: snd-atmel-abdac: test wrong variable

At Sun, 21 Nov 2010 20:40:07 +0300, Vasiliy Kulikov wrote:

After clk_get() pclk is checked second time instead of sample_clk check.

Signed-off-by: Vasiliy Kulikov segoon@openwall.com

Applied now. Thanks.

Takashi

---

Compile tested only.

sound/atmel/abdac.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/atmel/abdac.c b/sound/atmel/abdac.c index f2f41c8..4e47baa 100644 --- a/sound/atmel/abdac.c +++ b/sound/atmel/abdac.c @@ -420,7 +420,7 @@ static int __devinit atmel_abdac_probe(struct platform_device *pdev) return PTR_ERR(pclk); } sample_clk = clk_get(&pdev->dev, "sample_clk");

• if (IS_ERR(pclk)) {

• if (IS_ERR(sample_clk)) { dev_dbg(&pdev->dev, "no sample clock\n"); retval = PTR_ERR(pclk); goto out_put_pclk;

-- 1.7.0.4