-----Original Message----- From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org] Sent: 03 January 2023 04:41 PM To: Padmanabhan Rajanbabu p.rajanbabu@samsung.com; lgirdwood@gmail.com; broonie@kernel.org; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; s.nawrocki@samsung.com; perex@perex.cz; tiwai@suse.com; pankaj.dubey@samsung.com; alim.akhtar@samsung.com; rcsekar@samsung.com; aswani.reddy@samsung.com Cc: alsa-devel@alsa-project.org; devicetree@vger.kernel.org; linux- kernel@vger.kernel.org; linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 4/5] arm64: dts: fsd: Add codec node for Tesla FSD
On 03/01/2023 05:56, Padmanabhan Rajanbabu wrote:
Add device tree node support for codec on Tesla FSD platform.
Signed-off-by: Padmanabhan Rajanbabu p.rajanbabu@samsung.com
arch/arm64/boot/dts/tesla/fsd-evb.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts b/arch/arm64/boot/dts/tesla/fsd-evb.dts index cf5f2ce4d2a7..e2fd49774f15 100644 --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts @@ -10,6 +10,7 @@
/dts-v1/; #include "fsd.dtsi" +#include <dt-bindings/gpio/gpio.h>
/ { model = "Tesla Full Self-Driving (FSD) Evaluation board"; @@ -34,6 +35,18 @@ clock-frequency = <24000000>; };
+&hsi2c_5 {
- status = "okay";
- tlv320aic3x: codec@18 {
#sound-dai-cells = <0>;compatible = "ti,tlv320aic3104";reg = <0x18>;First compatible, then reg, then the rest.
Okay, I'll update the same in the next patch set.
reset-gpios = <&gpg1 6 GPIO_ACTIVE_LOW>;status = "okay";It's by default. Why do you need it?
Okay, I understood that if there is no status entry, it is treated as "okay". I'll update the same in the next patch set.
Best regards, Krzysztof
Thanks, Padmanabhan R.