
Thanks Mark for reviewing.
On 7/9/2018 4:44 PM, Mark Brown wrote:
On Fri, Jul 06, 2018 at 03:13:13PM +0530, Rohit kumar wrote:
@@ -0,0 +1,390 @@ +// SPDX-License-Identifier: GPL-2.0 +/*
- Copyright (c) 2018, The Linux Foundation. All rights reserved.
- */
Please make the entire comment block a C++ comment, it makes it look more intentional.
Sure, will make this change in next patchset.
+static const struct component_master_ops sdm845_ops = {
- .bind = sdm845_bind,
- .unbind = sdm845_unbind,
+};
Why is this using the component stuff rather than the normal support for finding the components of audio cards?
QCOM soundcard is dependent on platform and cpu dais which gets registered only when ADSP is up. This is the design being followed in https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/soun... We too have the same dependency.
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Thanks, Rohit