On 2019-08-26 18:39, Pierre-Louis Bossart wrote:
On 8/24/19 5:54 AM, Cezary Rojewski wrote:
On 2019-08-23 22:18, Pierre-Louis Bossart wrote:
On 8/22/19 2:04 PM, Cezary Rojewski wrote:
To this date Skylake SST were following ill flow of initialization by
'ill' as in 'sick'? that's probably a bit strong and judgmental? or is this a typo?
ill seems like a perfect opposite of healthy, ain't it? Because certainly, the initialization pattern observed in /skylake is everything but healthy.
I don't know what 'healthy' means either in this context.
s/ill/incorrect/?
In essence, most of what is required is actually done even in existing /skylake init. How it is done leaves a lot to be desired, though. Initialization is cleaned up to improve code quality and make it look cohesive - removal of duplications, usage of sst-framework functions and so on.
Followup segments - including but not limited to power-management - touch this stuff quite a bit. With initialization updated, each power-management patch fixes single spot rather than 3 (skl-sst, bxt-sst, cnl-sst). Should probe more readable and easy to review.
That's why I described it via 'ill'. Although I do agree, could have chosen a better description.