On Mon, Sep 14, 2015 at 12:52:55PM +0100, Charles Keepax wrote:
On Mon, Sep 14, 2015 at 01:54:39PM +0200, Pavel Machek wrote:
Hi!
I've got an embedded system with two arizona / wm5102 codecs.
Unfortunately, kernel does not seem to be ready for that configuration.
In particular, drivers/regulator/arizona-ldo1.c and drivers/regulator/arizona-micsupp.c register system-wide "MICVDD" and "LDO1" regulators, but with two codecs in the system, we really have wm5102-codec.1.MICVDD, wm5102-codec.2.MICVDD, wm5102-codec.1.LDO1 and wm5102-codec.2.LDO1.
That got me second codec working in two-codec configuration, but first one still stops working as soon as two codecs are enabled.
If you have idea what else needs fixing, let me know.
Best regards, Pavel
I must confess I haven't ever tested a system with two Arizona CODECs connected. Yes it seems you would get clashes on the regulator names, I guess that would need to be fixed up. If you were doing so wm831x-ldo.c would probably make a reasonable example.
I guess you would need to be careful with the machine driver as well, you will need to use a snd_soc_codec_conf structure for at least one (although I would do both) of the CODECs to give a prefix for all the widget/control names, otherwise those will clash and everything will probably behave very strangely. See sound/soc/samsung/bells.c for an example doing this for wm9081.
Those are the only two things that spring to mind at the moment but keep me informed on how you are getting on and I will let you know if I can come up with any other traps.
Oh and one more all the calls to mfd_add_devices in arizona-core.c use PLATFORM_DEVID_NONE at the moment, which I suspect will also cause problems at some point.
Thanks, Charles