Re: [alsa-devel] [PATCH v8 2/3] x86: add support for Huawei WMI hotkeys.

On Fri, Nov 30, 2018 at 1:58 AM Ayman Bagabas ayman.bagabas@gmail.com wrote:

+static int huawei_wmi_micmute_led_set(struct led_classdev *led_cdev,

•           enum led_brightness brightness)
  

+{

•   struct huawei_wmi_priv *priv = dev_get_drvdata(led_cdev->dev->parent);
  

•   acpi_status status;
  

•   union acpi_object args[3];
  

•   struct acpi_object_list arg_list = {
  

•           .pointer = args,
  

•           .count = ARRAY_SIZE(args),
  

•   };
  

•   args[0].type = args[1].type = args[2].type = ACPI_TYPE_INTEGER;
  

•   args[0].integer.value = 0;
  

•   args[1].integer.value = 0x04;
  

•   args[2].integer.value = brightness ? 1 : 0;
  

•   if (strcmp(priv->acpi_method, "WPIN") == 0) {
  

•           args[0].integer.value = 1;
  

•           args[2].integer.value = brightness ? 0 : 1;
  

•   }
  

I would rather still see explicit settings for the other method as well. Something like:

if (strcmp(...)) { } else if (strcmp(...)) { } else { return -EINVAL; }

•   status = acpi_evaluate_object(priv->handle, priv->acpi_method, &arg_list, NULL);
  

•   if (ACPI_FAILURE(status))
  

•           return -ENXIO;
  

•   return 0;
  

+}

+static int huawei_wmi_leds_setup(struct wmi_device *wdev) +{

•   struct huawei_wmi_priv *priv = dev_get_drvdata(&wdev->dev);
  

•   acpi_status status;
  

•   // Skip registering LED subsystem if no ACPI method was found.
  

•   status = acpi_get_handle(priv->handle, "\\_SB.PCI0.LPCB.EC0", &priv->handle);
  

•   if (ACPI_FAILURE(status))
  

•           return 0;
  

•   if (acpi_has_method(priv->handle, "SPIN"))
  

•           priv->acpi_method = "SPIN";
  

•   else if (acpi_has_method(priv->handle, "WPIN"))
  

•           priv->acpi_method = "WPIN";
  

•   else
  

•           return 0;
  

•   priv->cdev.name = "platform::micmute";
  

•   priv->cdev.max_brightness = 1;
  

•   priv->cdev.brightness_set_blocking = huawei_wmi_micmute_led_set;
  

•   priv->cdev.default_trigger = "audio-micmute";
  

•   priv->cdev.brightness = ledtrig_audio_get(LED_AUDIO_MICMUTE);
  

•   priv->cdev.dev = &wdev->dev;
  

•   return devm_led_classdev_register(&wdev->dev, &priv->cdev);
  

+}

+static void huawei_wmi_process_key(struct wmi_device *wdev, int code) +{

•   struct huawei_wmi_priv *priv = dev_get_drvdata(&wdev->dev);
  

•   const struct key_entry *key;
  

•   /*
  

•    * WMI0 uses code 0x80 to indicate a hotkey event.
  

•    * The actual key is fetched from the method WQ00.
  

•    */
  

•   if (code == 0x80) {
  

•           acpi_status status;
  

•           acpi_handle handle;
  

•           unsigned long long result;
  

•           union acpi_object args[1];
  

•           struct acpi_object_list arg_list = {
  

•                   .pointer = args,
  

•                   .count = ARRAY_SIZE(args),
  

•           };
  

•           args[0].type = ACPI_TYPE_INTEGER;
  

•           args[0].integer.value = 0;
  

•           status = acpi_get_handle(NULL, "\\WMI0", &handle);
  

•           if (ACPI_FAILURE(status)) {
  

•                   dev_err(&wdev->dev, "Unable to get ACPI handle\n");
  

•                   return;
  

•           }
  

•           status = acpi_evaluate_integer(NULL, "WQ00", &arg_list, &result);
  

•           if (ACPI_FAILURE(status)) {
  

•                   dev_err(&wdev->dev, "Unable to evaluate ACPI method\n");
  

•                   return;
  

•           }
  

•           code = result;
  

•   }
  

•   key = sparse_keymap_entry_from_scancode(priv->idev, code);
  

•   if (!key) {
  

•           dev_info(&wdev->dev, "Unknown key pressed, code: 0x%04x\n", code);
  

•           return;
  

•   }
  

•   sparse_keymap_report_entry(priv->idev, key, 1, true);
  

+}

+static void huawei_wmi_notify(struct wmi_device *wdev,

•           union acpi_object *obj)
  

+{

•   if (obj->type == ACPI_TYPE_INTEGER)
  

•           huawei_wmi_process_key(wdev, obj->integer.value);
  

•   else
  

•           dev_info(&wdev->dev, "Bad response type %d\n", obj->type);
  

+}

+static int huawei_wmi_input_setup(struct wmi_device *wdev) +{

•   struct huawei_wmi_priv *priv = dev_get_drvdata(&wdev->dev);
  

•   int err;
  

•   priv->idev = devm_input_allocate_device(&wdev->dev);
  

•   if (!priv->idev)
  

•           return -ENOMEM;
  

•   priv->idev->name = "Huawei WMI hotkeys";
  

•   priv->idev->phys = "wmi/input0";
  

•   priv->idev->id.bustype = BUS_HOST;
  

•   priv->idev->dev.parent = &wdev->dev;
  

•   err = sparse_keymap_setup(priv->idev, huawei_wmi_keymap, NULL);
  

•   if (err)
  

•           return err;
  

•   err = input_register_device(priv->idev);
  

•   if (err)
  

•           return err;
  

•   return 0;
  

+}

+static int huawei_wmi_probe(struct wmi_device *wdev) +{

•   struct huawei_wmi_priv *priv;
  

•   int err;
  

•   priv = devm_kzalloc(&wdev->dev, sizeof(struct huawei_wmi_priv), GFP_KERNEL);
  

•   if (!priv)
  

•           return -ENOMEM;
  

•   dev_set_drvdata(&wdev->dev, priv);
  

•   err = huawei_wmi_input_setup(wdev);
  

•   if (err)
  

•           return err;
  

•   err = huawei_wmi_leds_setup(wdev);
  

•   if (err)
  

•           return err;
  

•   return 0;
  

+}

+static const struct wmi_device_id huawei_wmi_id_table[] = {

•   { .guid_string = WMI0_EVENT_GUID },
  

•   { .guid_string = AMW0_EVENT_GUID },
  

•   {  }
  

+};

+static struct wmi_driver huawei_wmi_driver = {

•   .driver = {
  

•           .name = "huawei-wmi",
  

•   },
  

•   .id_table = huawei_wmi_id_table,
  

•   .probe = huawei_wmi_probe,
  

•   .notify = huawei_wmi_notify,
  

+};

+static int __init huawei_wmi_init(void) +{

•   if (!(wmi_has_guid(WMI0_EVENT_GUID) || wmi_has_guid(AMW0_EVENT_GUID))) {
  

•           pr_debug("Compatible WMI GUID not found\n");
  

•           return -ENODEV;
  

•   }
  

•   return wmi_driver_register(&huawei_wmi_driver);
  

+}

+static void __exit huawei_wmi_exit(void) +{

•   wmi_driver_unregister(&huawei_wmi_driver);
  

+}

+module_init(huawei_wmi_init); +module_exit(huawei_wmi_exit);

+MODULE_ALIAS("wmi:"WMI0_EVENT_GUID); +MODULE_ALIAS("wmi:"AMW0_EVENT_GUID); +MODULE_AUTHOR("Ayman Bagabas ayman.bagabas@gmail.com"); +MODULE_DESCRIPTION("Huawei WMI hotkeys");

+MODULE_LICENSE("GPL v2");

2.19.1