Re: [alsa-devel] [PATCH] ALSA: hda/realtek: Enable HP amp and mute LED on HP Folio 9480m

Takashi Iwai tiwai@suse.de writes:

Thanks! The new patch looks good, but I think we don't have to use the headset code, as your case looks more like a headphone, not a combo headset that needs the special handling. If so, the change can be reduced something like below. Could you check whether this is enough?

Yes, that seems a lot simpler and works fine. I did remove the led_power_filter setting; that doesn't seem relevant for GPIO-based leds, and isn't necessary on my device in any case.

This patch is now otherwise essentially the same as yours, with the addition of comments.

Thanks again for your help; it's always interesting to dive into some different area of the kernel and see how it works.