[alsa-devel] [PATCH 09/11] ASoC: add for_each_comp_order() macro

18 Sep 2018

From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
To be more readable code, this patch adds
new for_each_comp_order() macro, and replace existing code to it.
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
---
 include/sound/soc.h  |  5 +++++
 sound/soc/soc-core.c | 18 ++++++------------
 2 files changed, 11 insertions(+), 12 deletions(-)

diff --git a/include/sound/soc.h b/include/sound/soc.h
index 52bc289..f1dab1f 100644
--- a/include/sound/soc.h
+++ b/include/sound/soc.h
@@ -372,6 +372,11 @@
 #define SND_SOC_COMP_ORDER_LATE		1
 #define SND_SOC_COMP_ORDER_LAST		2
+#define for_each_comp_order(order)		\
+	for (order  = SND_SOC_COMP_ORDER_FIRST;	\
+	     order <= SND_SOC_COMP_ORDER_LAST;	\
+	     order++)
+
 /*
  * Bias levels
  *
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index d583602..8f56725a 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -995,14 +995,12 @@ static void soc_remove_dai_links(struct snd_soc_card *card)
    struct snd_soc_pcm_runtime *rtd;
    struct snd_soc_dai_link *link, *_link;
-	for (order = SND_SOC_COMP_ORDER_FIRST; order <= SND_SOC_COMP_ORDER_LAST;
-			order++) {
+	for_each_comp_order(order) {
    	for_each_card_rtds(card, rtd)
    		soc_remove_link_dais(card, rtd, order);
    }
-	for (order = SND_SOC_COMP_ORDER_FIRST; order <= SND_SOC_COMP_ORDER_LAST;
-			order++) {
+	for_each_comp_order(order) {
    	for_each_card_rtds(card, rtd)
    		soc_remove_link_components(card, rtd, order);
    }
@@ -1620,8 +1618,7 @@ static int soc_probe_aux_devices(struct snd_soc_card *card)
    int order;
    int ret;
-	for (order = SND_SOC_COMP_ORDER_FIRST; order <= SND_SOC_COMP_ORDER_LAST;
-		order++) {
+	for_each_comp_order(order) {
    	list_for_each_entry(comp, &card->aux_comp_list, card_aux_list) {
    		if (comp->driver->probe_order == order) {
    			ret = soc_probe_component(card,	comp);
@@ -1643,8 +1640,7 @@ static void soc_remove_aux_devices(struct snd_soc_card *card)
    struct snd_soc_component *comp, *_comp;
    int order;
-	for (order = SND_SOC_COMP_ORDER_FIRST; order <= SND_SOC_COMP_ORDER_LAST;
-		order++) {
+	for_each_comp_order(order) {
    	list_for_each_entry_safe(comp, _comp,
    		&card->aux_comp_list, card_aux_list) {
@@ -2016,8 +2012,7 @@ static int snd_soc_instantiate_card(struct snd_soc_card *card)
    }
/* probe all components used by DAI links on this card */
-	for (order = SND_SOC_COMP_ORDER_FIRST; order <= SND_SOC_COMP_ORDER_LAST;
-			order++) {
+	for_each_comp_order(order) {
    	for_each_card_rtds(card, rtd) {
    		ret = soc_probe_link_components(card, rtd, order);
    		if (ret < 0) {
@@ -2050,8 +2045,7 @@ static int snd_soc_instantiate_card(struct snd_soc_card *card)
    }
/* probe all DAI links on this card */
-	for (order = SND_SOC_COMP_ORDER_FIRST; order <= SND_SOC_COMP_ORDER_LAST;
-			order++) {
+	for_each_comp_order(order) {
    	for_each_card_rtds(card, rtd) {
    		ret = soc_probe_link_dais(card, rtd, order);
    		if (ret < 0) {
-- 
2.7.4


    