23 Oct
2013
23 Oct
'13
7:14 p.m.
Emitting an OOM message isn't necessary after input_allocate_device as there's a generic OOM and a dump_stack already done.
Signed-off-by: Joe Perches joe@perches.com --- sound/pci/hda/hda_beep.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/pci/hda/hda_beep.c b/sound/pci/hda/hda_beep.c index 63c9909..20d065a 100644 --- a/sound/pci/hda/hda_beep.c +++ b/sound/pci/hda/hda_beep.c @@ -151,10 +151,8 @@ static int snd_hda_do_attach(struct hda_beep *beep) int err;
input_dev = input_allocate_device(); - if (!input_dev) { - printk(KERN_INFO "hda_beep: unable to allocate input device\n"); + if (!input_dev) return -ENOMEM; - }
/* setup digital beep device */ input_dev->name = "HDA Digital PCBeep";
--
1.8.1.2.459.gbcd45b4.dirty