Re: [PATCH v1] sound/pci/hda/patch_realtek: don't call alc_shutup_pins without a spec

14 Nov 2022


      On Mon, 14 Nov 2022 09:35:10 +0100,
Daniil Tatianin wrote:
...
On 11/14/22 11:26 AM, Takashi Iwai wrote:
...
On Mon, 14 Nov 2022 09:20:48 +0100,
Daniil Tatianin wrote:
...
alc_shutup_pins always expects the spec to be present, so make sure
it is before we call it.
Found by Linux Verification Center (linuxtesting.org) with the SVACE
static analysis tool.
Signed-off-by: Daniil Tatianin d-tatianin@yandex-team.ru
In which path can it be without spec assigned?
That's the internal callback that is set only by the codec driver
where the allocation of codec->spec is mandatory.
Would you then say that the "if (spec && ...)" that was there before
was redundant?
Yes.
Takashi