Re: [alsa-devel] [PATCH 06/21] ASoC: SOF: Intel: Add Intel specific HDA DSP HW operations

On Tue, 11 Dec 2018 22:30:14 +0100, Pierre-Louis Bossart wrote:

+int hda_dsp_resume(struct snd_sof_dev *sdev) +{

• struct hdac_bus *bus = sof_to_bus(sdev);
• int ret;
• /* turn display power on */
• ret = hda_codec_i915_get(sdev);

OK, we need to change this one for following my latest HD-audio PM refactoring...

• if (ret < 0) {

• dev_err(bus->dev, "error: cannot turn on display power on i915 after resume\n");
  

• return ret;
  

• }
• /* init hda controller and power dsp up */
• return hda_resume(sdev);

+}

+int hda_dsp_runtime_resume(struct snd_sof_dev *sdev) +{

• /* init hda controller and power dsp up */
• return hda_resume(sdev);

+}

But why can't runtime PM turn on/off the display power?

thanks,

Takashi