12 May
2009
12 May
'09
11:50 p.m.
On Tue, May 12, 2009 at 07:43:04PM +0200, Karl Beldan wrote:
Mark Brown wrote:
I'm out of time to look at this today - I expect that the fix is probably to move some version of the port reset change into this patch.
I'd go for moving port reset into 2/4 (or 1/4 ?), 3/4 would just remove clk_disable(clk_i2s) and leave the FIFO flushes as is, and keeping 4/4. What do you say ?
That sounds reasonable - I've already applied your first patch to reset everything on startup so no need to resend that (I forgot to push before leaving work). Might be as well to just merge the removal of the reset into the patch to handle playback and capture separately but either way is OK.
The suspend/resume change is fine.