Re: [alsa-devel] [PATCH 7/7] ASoC: Intel: sst - add compressed ops handling

On Fri, Jul 18, 2014 at 12:48:23PM +0100, Mark Brown wrote:

On Wed, Jul 09, 2014 at 02:57:55PM +0530, Vinod Koul wrote:

...

• if (codec->codec == SND_AUDIOCODEC_MP3) {

• codec->num_descriptors = 2;
  

• codec->descriptor[0].max_ch = 2;
  

• codec->descriptor[0].sample_rates[0] = 48000;
  

• codec->descriptor[0].sample_rates[1] = 44100;
  

• codec->descriptor[0].sample_rates[2] = 32000;
  

• codec->descriptor[0].sample_rates[3] = 16000;
  

• codec->descriptor[0].sample_rates[4] = 8000;
  

• codec->descriptor[0].num_sample_rates = 5;
  

• codec->descriptor[0].bit_rate[0] = 320; /* 320kbps */
  

• codec->descriptor[0].bit_rate[1] = 192;
  

• codec->descriptor[0].num_bitrates = 2;
  

• codec->descriptor[0].profiles = 0;
  

• codec->descriptor[0].modes = SND_AUDIOCHANMODE_MP3_STEREO;
  

• codec->descriptor[0].formats = 0;
  

It'd be more idiomatic to copy a static variable.

will update...