Re: [alsa-devel] [PATCH] ASoC: alc5632: rename volume/switch contols for master and speaker volumes.

On Sun, Nov 13, 2011 at 09:53:13PM +0200, Leon Romanovsky wrote:

• SOC_DOUBLE_TLV("Line Playback Volume",

• SOC_DOUBLE_TLV("Speaker Playback Volume", ALC5632_SPK_OUT_VOL, 8, 0, 31, 1, hp_tlv),

This looks really suspicious, why are we renaming the line output as a speaker output? This might be appropriate on your board but if the drivers aren't part of the CODEC it might not be appropriate on another board.

	ALC5632_LINE_IN_VOL, 8, 0, 31, 1, vol_tlv),

• SOC_DOUBLE_TLV("Stereo DAC Playback Volume",

• SOC_DOUBLE_TLV("Master Playback Volume", ALC5632_STEREO_DAC_IN_VOL, 8, 0, 63, 1, vdac_tlv),

• SOC_DOUBLE("Stereo DAC Playback Switch",

• SOC_DOUBLE("Master Playback Switch",

This looks fine.