Re: [PATCH] ASoC: Intel: mtl-match: Add cs42l43_l0 cs35l56_l23 for MTL

On Mon, Jan 22, 2024 at 03:01:56PM +0000, Maciej Strozek wrote:

Signed-off-by: Maciej Strozek mstrozek@opensource.cirrus.com

.../intel/common/soc-acpi-intel-mtl-match.c | 56 +++++++++++++++++++ 1 file changed, 56 insertions(+)

diff --git a/sound/soc/intel/common/soc-acpi-intel-mtl-match.c b/sound/soc/intel/common/soc-acpi-intel-mtl-match.c index feb12c6c85d1..625f991b1ad4 100644 --- a/sound/soc/intel/common/soc-acpi-intel-mtl-match.c +++ b/sound/soc/intel/common/soc-acpi-intel-mtl-match.c @@ -377,6 +377,36 @@ static const struct snd_soc_acpi_adr_device cs35l56_2_adr[] = { } };

+static const struct snd_soc_acpi_adr_device cs35l56_2_r_adr[] = {

• {

• .adr = 0x00023301FA355601ull,
  

• .num_endpoints = 1,
  

• .endpoints = &spk_r_endpoint,
  

• .name_prefix = "AMP3"
  

• },
• {

• .adr = 0x00023201FA355601ull,
  

• .num_endpoints = 1,
  

• .endpoints = &spk_3_endpoint,
  

• .name_prefix = "AMP4"
  

• }

+};

Sorry the amp ordering is still weird here, can we have:

static const struct snd_soc_acpi_adr_device cs35l56_2_r_adr[] = { { .adr = 0x00023201FA355601ull, .num_endpoints = 1, .endpoints = &spk_r_endpoint, .name_prefix = "AMP3" }, { .adr = 0x00023301FA355601ull, .num_endpoints = 1, .endpoints = &spk_3_endpoint, .name_prefix = "AMP4" } };

Thanks, Charles

+static const struct snd_soc_acpi_adr_device cs35l56_3_l_adr[] = {

• {

• .adr = 0x00033001fa355601ull,
  

• .num_endpoints = 1,
  

• .endpoints = &spk_l_endpoint,
  

• .name_prefix = "AMP1"
  

• },
• {

• .adr = 0x00033101fa355601ull,
  

• .num_endpoints = 1,
  

• .endpoints = &spk_2_endpoint,
  

• .name_prefix = "AMP2"
  

• }

+};