Re: [alsa-devel] DPCM: suspicious code in dpcm_prune_paths()

On Tue, Sep 10, 2019 at 11:20:17AM +0200, Guennadi Liakhovetski wrote:

This code in dpcm_prune_paths() seems to have no effect:

/* is there a valid CODEC DAI widget for this BE */
for_each_rtd_codec_dai(dpcm->be, i, dai) {
	widget = dai_get_widget(dai, stream);

	/* prune the BE if it's no longer in our active list */
	if (widget && widget_in_list(list, widget))
		continue;
}

Neither of the variables, that are modified in this loop are used outside of it. Was the "continue" maybe meant to continue the encompassing loop?

Liam?